Closed aboimpinto closed 5 years ago
Merging #528 into development will decrease coverage by
0.55%
. The diff coverage is8.79%
.
@@ Coverage Diff @@
## development #528 +/- ##
===============================================
- Coverage 49.92% 49.36% -0.56%
===============================================
Files 315 315
Lines 12908 13060 +152
===============================================
+ Hits 6444 6447 +3
- Misses 6464 6613 +149
Impacted Files | Coverage Δ | |
---|---|---|
...lication/Attributes/ConsoleOutputStyleAttribute.cs | 0% <0%> (ø) |
:arrow_up: |
src/NeoSharp.Persistence.RocksDB/RocksDbContext.cs | 0% <0%> (ø) |
:arrow_up: |
...Sharp.Core/Blockchain/Processing/BlockPersister.cs | 0% <0%> (ø) |
:arrow_up: |
...Core/Blockchain/Processing/TransactionPersister.cs | 100% <100%> (ø) |
:arrow_up: |
.../NeoSharp.Persistence.RocksDB/RocksDbRepository.cs | 80.22% <44.82%> (-6.82%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc84bf6...7f60a00. Read the comment docs.
well ... yes .. it woks and this is the code:
public void Rollback(Enlistment enlistment) { _currentWriteBatch.Dispose(); _currentWriteBatch = null; enlistment.Done(); }
mean that all the write batch is discarded and not executed ...
make all the sense in any case ... but if you don't like, there is nothing that I can do ...
To make sure that when we save a block all the data is "all in" or "all out", transaction support is need.