Closed shargon closed 5 years ago
Merging #537 into development will decrease coverage by
0.19%
. The diff coverage is39.8%
.
@@ Coverage Diff @@
## development #537 +/- ##
=============================================
- Coverage 49.4% 49.2% -0.2%
=============================================
Files 315 315
Lines 13049 13104 +55
=============================================
+ Hits 6447 6448 +1
- Misses 6602 6656 +54
Impacted Files | Coverage Δ | |
---|---|---|
...NeoSharp.Core/Messaging/Messages/MemPoolMessage.cs | 0% <ø> (ø) |
:arrow_up: |
.../NeoSharp.Core/Messaging/Messages/VerAckMessage.cs | 100% <ø> (ø) |
:arrow_up: |
...NeoSharp.Core/Messaging/Messages/GetAddrMessage.cs | 0% <ø> (ø) |
:arrow_up: |
...harp.Core/Messaging/Messages/FilterClearMessage.cs | 0% <ø> (ø) |
:arrow_up: |
...rc/NeoSharp.Core/Messaging/Messages/AddrMessage.cs | 15.62% <0%> (-2.9%) |
:arrow_down: |
...oSharp.Core/Messaging/Messages/FilterAddMessage.cs | 33.33% <0%> (-16.67%) |
:arrow_down: |
...arp.Core/Messaging/Messages/BlockHeadersMessage.cs | 18.51% <0%> (-4.21%) |
:arrow_down: |
...oSharp.Core/Messaging/Messages/ConsensusMessage.cs | 26.08% <0%> (-7.25%) |
:arrow_down: |
...NeoSharp.Core/Messaging/Messages/GetDataMessage.cs | 33.33% <0%> (-16.67%) |
:arrow_down: |
src/NeoSharp.Application/DI/PersistenceModule.cs | 0% <0%> (ø) |
:arrow_up: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eb80bbd...9614000. Read the comment docs.
Now, the constructor of the message is with the payload, so we prevent to create twice the payload, one on constructor, and other for deserialization