search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Fix ConsensusPayload serialization issue #539

Closed shargon closed 5 years ago

shargon commented 5 years ago

ScriptPrefix was not serialized because was private, so the message was wrong deserialized

codecov[bot] commented 5 years ago

Codecov Report

Merging #539 into development will increase coverage by 0.05%. The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #539      +/-   ##
===============================================
+ Coverage        49.21%   49.26%   +0.05%     
===============================================
  Files              315      315              
  Lines            13103    13088      -15     
===============================================
  Hits              6448     6448              
+ Misses            6655     6640      -15
Impacted Files Coverage Δ
src/NeoSharp.Core/Network/Tcp/TcpPeer.cs 0% <0%> (ø) :arrow_up:
...oSharp.Core/Messaging/Messages/ConsensusMessage.cs 50% <50%> (+23.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3892f0c...fb0f25f. Read the comment docs.