search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Fix #412 Core: Test: NEP6WalletTest: Improve address verification testing #543

Closed melanke closed 5 years ago

melanke commented 5 years ago

Fix #412

I didn't improve the Nep6WalletManager tests, but I created many methods involving the Wallet address composition on other classes

codecov[bot] commented 5 years ago

Codecov Report

Merging #543 into development will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #543      +/-   ##
===============================================
- Coverage        49.26%   49.25%   -0.02%     
===============================================
  Files              315      315              
  Lines            13088    13085       -3     
===============================================
- Hits              6448     6445       -3     
  Misses            6640     6640
Impacted Files Coverage Δ
src/NeoSharp.Core/Wallet/Helpers/WalletHelper.cs 93.7% <100%> (-0.09%) :arrow_down:
src/NeoSharp.Core/Wallet/Helpers/Extensions.cs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a98d72d...31030f6. Read the comment docs.