Closed osmirnov closed 5 years ago
Merging #546 into development will decrease coverage by
9.01%
. The diff coverage is1.29%
.
@@ Coverage Diff @@
## development #546 +/- ##
===============================================
- Coverage 49.26% 40.25% -9.02%
===============================================
Files 317 348 +31
Lines 13157 16103 +2946
===============================================
Hits 6482 6482
- Misses 6675 9621 +2946
Impacted Files | Coverage Δ | |
---|---|---|
src/NeoSharp.Core/Wallet/NEP6/NEP6Wallet.cs | 100% <ø> (ø) |
:arrow_up: |
...eoSharp.Core/Wallet/Invocation/InvocationResult.cs | 100% <ø> (ø) |
:arrow_up: |
src/NeoSharp.VM/IExecutionEngine.cs | 20% <ø> (ø) |
:arrow_up: |
....Core/Wallet/JsonConverter/NEP6AccountConverter.cs | 66.66% <ø> (ø) |
:arrow_up: |
src/NeoSharp.Core/Wallet/NEP6/NEP6WalletManager.cs | 74.04% <ø> (ø) |
:arrow_up: |
src/NeoSharp.Core/Cryptography/ECPoint.cs | 100% <ø> (ø) |
:arrow_up: |
...c/NeoSharp.Core/Converters/JsonConverterWrapper.cs | 100% <ø> (ø) |
:arrow_up: |
src/NeoSharp.Core/Helpers/FileWrapper.cs | 100% <ø> (ø) |
:arrow_up: |
src/NeoSharp.Core/Types/TransactionContext.cs | 1.96% <ø> (ø) |
:arrow_up: |
src/NeoSharp.Core/DI/Modules/HelpersModule.cs | 78.57% <ø> (ø) |
:arrow_up: |
... and 75 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e1a4a14...6716bdf. Read the comment docs.
@osmirnov there are problems with items like interopStackItem, i will deal with it on :
https://github.com/neo-project/neo-vm/pull/67 this solution will help with this issues
@osmirnov please review the last changes, is using a compiled version of NeoVM with the last changes.
Execution successful of virtual smart contract
virtual contract add 0x0066
testinvoke 0x9e5bf7f291e4d8edd25e7b3c790c6f11590f9754 Application
Now is used the nuGet package, Erik released this version :)
@osmirnov do you know why travis is throwing an exception?
@osmirnov do you know why travis is throwing an exception?
Yes, I think it is related to https://github.com/CityOfZion/neo-sharp/pull/548/files#diff-432d787ad9965e43ec651da1be56928dR80 not to this PR
I've started the implementation of NeoVM support. My goal not only make it running but generalize the API and adapt HyperVM later.