CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Real SC unit test, with json format #554

Closed shargon closed 5 years ago

shargon commented 5 years ago

Still working on this, don't merge

shargon commented 5 years ago

@osmirnov we need to use InteropService with dummy storages (Dictionaries) without write all the logic again for unit testing

codecov[bot] commented 5 years ago

Codecov Report

Merging #554 into development will increase coverage by 5.83%. The diff coverage is 70.16%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #554      +/-   ##
===============================================
+ Coverage        44.35%   50.19%   +5.83%     
===============================================
  Files              356      356              
  Lines            16070    16131      +61     
===============================================
+ Hits              7128     8097     +969     
+ Misses            8942     8034     -908
Impacted Files Coverage Δ
src/NeoSharp.Core/VM/CloneCache.cs 35% <ø> (+35%) :arrow_up:
src/NeoSharp.Core/VM/DataCache.cs 49.4% <0%> (+49.4%) :arrow_up:
...p.Application/Controllers/PromptDebugController.cs 0% <0%> (ø) :arrow_up:
src/NeoSharp.VM/Types/Instruction.cs 0% <0%> (ø) :arrow_up:
...Sharp.VM/Extensions/InstructionParserExtensions.cs 0% <0%> (ø)
src/NeoSharp.VM/Types/InstructionWithPayload.cs 0% <0%> (ø) :arrow_up:
test/NeoSharp.VM.TestHelper/VMUTStep.cs 100% <100%> (ø) :arrow_up:
src/NeoSharp.Core/VM/StateMachine.cs 22.92% <100%> (+22.92%) :arrow_up:
src/NeoSharp.VM/Arguments/LogEventArgs.cs 100% <100%> (+100%) :arrow_up:
src/NeoSharp.Core/VM/StackAccessor.cs 45.45% <100%> (+45.45%) :arrow_up:
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d0cb16...5fa0f61. Read the comment docs.

shargon commented 5 years ago

@osmirnov please review the json format. If you think that we need to rename some of them tell me :)

shargon commented 5 years ago

I will merge it until we found a better naming for json