CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Merge StackAccessor with Stack #555

Closed osmirnov closed 5 years ago

osmirnov commented 5 years ago

Two major changes:

codecov[bot] commented 5 years ago

Codecov Report

Merging #555 into development will increase coverage by 0.09%. The diff coverage is 50.74%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #555      +/-   ##
===============================================
+ Coverage        50.19%   50.28%   +0.09%     
===============================================
  Files              356      355       -1     
  Lines            16131    16034      -97     
===============================================
- Hits              8097     8063      -34     
+ Misses            8034     7971      -63
Impacted Files Coverage Δ
src/NeoSharp.VM/ExecutionEngineBase.cs 80% <ø> (ø) :arrow_up:
src/NeoSharp.Core/VM/InteropServiceExtensions.cs 100% <100%> (ø) :arrow_up:
src/NeoSharp.VM.NeoVM/ApplicationEngine.cs 99.64% <100%> (-0.04%) :arrow_down:
src/NeoSharp.Core/VM/StateMachine.cs 21.23% <23.07%> (-1.7%) :arrow_down:
src/NeoSharp.VM/Types/InteropService.cs 53.35% <29.41%> (+1.05%) :arrow_up:
src/NeoSharp.VM/Collections/Stack.cs 38.46% <31.57%> (+38.46%) :arrow_up:
src/NeoSharp.VM/Types/StackItemBinarySerializer.cs 36.12% <35.71%> (+1.27%) :arrow_up:
src/NeoSharp.VM.NeoVM/StackWrapper.cs 69.49% <44.44%> (+18.42%) :arrow_up:
.../NeoSharp.VM.NeoVM/StackExecutionContextWrapper.cs 50% <58.33%> (+2.94%) :arrow_up:
src/NeoSharp.Core/VM/StateReader.cs 30.65% <65.95%> (+0.41%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6659686...a828d9d. Read the comment docs.