CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Support for transaction height #557

Closed osmirnov closed 5 years ago

osmirnov commented 5 years ago

There are VM calls "System.Blockchain.GetTransactionHeight" and "Neo.Blockchain.GetTransactionHeight". We need to store height for transactions.

shargon commented 5 years ago

We need a new index? How is this done in the official repository?

osmirnov commented 5 years ago

They get this from transaction record offset in LevelDB. Yes I think it should extra field Id or something.

shargon commented 5 years ago

We can use a class like this?

class StoredTx
{
 uint Height;
 Transaction Tx;
}
osmirnov commented 5 years ago

Could we extend Transaction itself because we many derived classes as InvocationTransaction?