search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
34 stars 24 forks source link

Moved enumerators into InteropService #564

Closed osmirnov closed 5 years ago

osmirnov commented 5 years ago

I've moved enumerators into InteropService because they contain only plumbing logic for iteration on collections.

codecov[bot] commented 5 years ago

Codecov Report

Merging #564 into development will decrease coverage by 0.46%. The diff coverage is 16.24%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #564      +/-   ##
==============================================
- Coverage        50.56%   50.1%   -0.47%     
==============================================
  Files              356     359       +3     
  Lines            16074   16218     +144     
==============================================
- Hits              8128    8126       -2     
- Misses            7946    8092     +146
Impacted Files Coverage Δ
src/NeoSharp.VM/Collections/Stack.cs 38.46% <ø> (ø) :arrow_up:
src/NeoSharp.VM.NeoVM/StackWrapper.cs 69.49% <ø> (ø) :arrow_up:
src/NeoSharp.Core/VM/StateReader.cs 29.27% <0%> (-1.38%) :arrow_down:
...rc/NeoSharp.VM/Enumerators/ProjectingEnumerator.cs 0% <0%> (ø)
src/NeoSharp.VM/Enumerators/KeyEnumerator.cs 0% <0%> (ø)
.../NeoSharp.VM/Enumerators/ConcatenatedEnumerator.cs 0% <0%> (ø)
src/NeoSharp.VM/Types/InteropService.cs 41.76% <18.64%> (-11.6%) :arrow_down:
src/NeoSharp.Core/VM/DataCache.cs 49.4% <43.47%> (ø) :arrow_up:
src/NeoSharp.VM/ExecutionEngineBase.cs 66.66% <0%> (-13.34%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c78972...31457bc. Read the comment docs.