search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
34 stars 24 forks source link

Check witness on pubkey #569

Closed osmirnov closed 5 years ago

shargon commented 5 years ago

I think that the problem is that the process of serialize a Transaction was delegated to other class, right?

osmirnov commented 5 years ago

I would not say this is a problem but it impacts our code design a lot. I see benefits keeping Transaction class free from serizalization logic.

shargon commented 5 years ago

Maybe is better to set the message in binary format

osmirnov commented 5 years ago

It was before in binary format. In contrast to original NEO project our Transaction class is not able to be restored from byte array when it is casted to InvocationTransaction. This is the reason why we have two methods in MessageProvider class.