search

CityOfZion / neon-js

Javascript libraries that allow the applications to interact with NEO blockchain
https://docs.coz.io/neo3/neon-js/index.html
MIT License
183 stars 166 forks source link

feat(ledger): Updates after Ledger review #788

Closed ixje closed 2 years ago

ixje commented 3 years ago

Wait with merging. I need to add more new error codes

snowypowers commented 2 years ago

any updates?

ixje commented 2 years ago

I'm currently on holiday. The issue is still valid. There is a "but". Ledger has basically ignored us for 2 months now by saying "we don't have time" to review the ledger app updates we PR'ed for.

On Thu, Dec 16, 2021 at 5:12 AM Yak Jun Xiang @.***> wrote:

any updates?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CityOfZion/neon-js/pull/788#issuecomment-995423156, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRSANPQQSK4BOU5F4HL2TURFRKXANCNFSM5DR5FLBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

snowypowers commented 2 years ago

another ping, seems like ledger got the review through?

ixje commented 2 years ago

Yes! I’ll have a look at it today to make sure all fields still match

On 8 Feb 2022, at 07:17, Yak Jun Xiang @.***> wrote:

 another ping, seems like ledger got the review through?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

ixje commented 2 years ago

All good now