search

CityOfZion / neon-js

Javascript libraries that allow the applications to interact with NEO blockchain
https://docs.coz.io/neo3/neon-js/index.html
MIT License
183 stars 166 forks source link

BooleanWitnessCondition has no serialize method override #876

Closed xie-yue closed 1 year ago

xie-yue commented 1 year ago

in BooleanWitnessCondition

there is no serialize method override, so expression didn't work. for deserialize read byte for expression, next step deserializeAttributes throws en error 11 not found in TxAttrUsage!

related https://github.com/CityOfZion/neon-js/issues/872 @ixje

ixje commented 1 year ago

Sorry to see that. Hopefully the above PR fixes all remaining issues with WitnessConditions.

As for deserializeAttributes. That's a separate issue. Transaction attributes are something only committee members can set and as a result hardly ever seen. The current implementation is actually still based on NEO2

xie-yue commented 1 year ago

@ixje the pr works perfectly in my local environment, waiting for merge. thank you very much!

ixje commented 1 year ago

@xie-yue fyi; https://www.npmjs.com/package/@cityofzion/neon-js/v/5.2.2

xie-yue commented 1 year ago

works great! thx! @ixje