CU-864ekh1aw - new Account of NeonJS needs to accept '0x' and remove it if necessary

CityOfZion / neon-js

Javascript libraries that allow the applications to interact with NEO blockchain

https://docs.coz.io/neo3/neon-js/index.html

MIT License

183 stars 166 forks source link

CU-864ekh1aw - new Account of NeonJS needs to accept '0x' and remove it if necessary #895

Closed raulduartep closed 1 year ago

raulduartep commented 1 year ago

This PR is important to avoid problems when passing 0x on the scripthash to create a new Account. It seems unecessary at first but this constructor is being used by other libraries that tries to convert different kinds of input to an Address or ScriptHash.

lllwvlvwlll commented 1 year ago

Task linked: CU-864ekh1aw new Account of NeonJS needs to accept "0x" and remove it if necessary

melanke commented 1 year ago

@raulduartep actually I think this PR is not following neon-js directives: 1) The commit name doesn't follow the standard: https://www.conventionalcommits.org/en/v1.0.0/ 2) You need to send a PR from a fork, like simplitech/neon-js 3) You are sending to master but it should be dev

Check this PR example: https://github.com/CityOfZion/neon-js/pull/882