thiagocbalducci
commented
2 weeks ago Excellent points! I will create an internal issue to improve this.
You are on a roll :)
Open Voll3r opened 3 weeks ago
thiagocbalducci
commented
2 weeks ago Excellent points! I will create an internal issue to improve this.
You are on a roll :)
When importing a wallet from a mnemonic, the user is given the choice which specific accounts and also which types of accounts to import. This is a useful feature for sure, but the UI behaviour seems a little haphazard in places, making the process unintuitive and needlessly time consuming.
It seems to me the way the checkboxes are interconnected is not actually implemented as intended. In the worst case, the process is interrupted prematurely, the user has to start fresh and reenter the mnemonic.
At the starting point, all accounts are pre-selected. This is perfectly fine and I have no issues with that:
Deselecting any top checkmark will also deselect the corresponding bottom checkmark. This makes sense and is fine.
1. Unchecking bottom box also unchecks top box.
Deselecting any bottom checkmark with also deselect the top checkmark. This is unexpected and I'm guessing also unintended?
It seems all bottom checkboxes are linked to the top boxes when deselecting. It seems to me that this is actually a bug. In the worst case this will force the user to restart the import process (see item 4 below).
2. Checking bottom box does not force-check top box
I'm guessing the intention behind linking the checkboxes is that the user cannot import the second address without also importing the first?
However, if both boxes are unchecked and the user checks the bottom box, the top box will not be checked also.
Again this is the case for all account types and I'm assuming this is a bug.
3. Connection between NeoX and Etherium seems hapharzard
I'm not into NeoX, but from the checkbox behaviour I'm guessing that there is a dependency with Etherium which requires that a NeoX account must have a corresponding Etherium account and/or vice versa? If so, it makes sense to have some linkage in the checkboxes, but the current behaviour is not consistent:
E.g. unchecking the top box on NeoX will also uncheck the bottom box on NeoX (see item 1 above), but it will only uncheck the top box for Etherium. The bottom Etherium box remains checked:
Similarly (with all four boxes checked)
When none of the boxes are checked, there appears to be no linkage at all.
4. Unexpected interruption of workflow:
Consider the following scenario: a user wants to add a single N3 account. The user will uncheck all legacy, NeoX and Etherium accounts. As a last action, the user will uncheck the bottom tick box on N3. However, this will deselect both addresses and end the workflow:
The user has to restart the import process and reenter the mnemonic.
This would happen not just for N3, but for any situation in which deselecting the bottom box also unexpectedly unchecks the top box resulting in none of the boxes being checked.
Suggestion: rather than interrupting the workflow and forcing the user to reenter the mnemonic, the "Import" button should simply be greyed out when no accounts are selected.