search

CityOfZion / neon-wallet

Light wallet for the NEO blockchain
http://neonwallet.com
MIT License
1.03k stars 312 forks source link

Update labels related to Ledger authentication as per design #1335

Closed drptbl closed 6 years ago

drptbl commented 6 years ago

Wallet version or commit SHA: design-v2 branch (2d9cfc7)

Environment: Win 10 Home (64 bit) Version 1803 Build 17134.112

Reproduction steps:

No device found

  1. Start Neon Wallet
  2. Click on "Ledger" tab

NEO app is closed

  1. Start Neon Wallet
  2. Click on "Ledger" tab
  3. Connect Ledger with USB port
  4. Type your PIN on the Ledger

Found Ledger

  1. Start Neon Wallet
  2. Click on "Ledger" tab
  3. Connect Ledger with USB port
  4. Type your PIN on Ledger
  5. Start NEO app on Ledger

Issues:

No device found This case doesn't match the design.

NEO app is closed I imagine that it should be the same as for "No device found" just with modified error message.

Found Ledger I imagine that it should be the same as for "No device found", however there should be a checkmark instead of cross inside squared circle with success message. Currently there's a typo (in "~on hardward device" part).

I also think that current error and success messages should be consulted with Ben and improved.

Currently:

No device found no_device_current

NEO app is closed app_closed

Found Ledger found_usb

Expected:

No device found no_ledger

Designs for other cases are missing.

drptbl commented 6 years ago

Fixed.