search

CityOfZion / neon-wallet

Light wallet for the NEO blockchain
http://neonwallet.com
MIT License
1.03k stars 312 forks source link

Feature: Multisign Support #1695

Open belane opened 5 years ago

belane commented 5 years ago

Please add Multisign support for transfers and invocations. I think in the blockchain era it is a must.

It can cover both cases, when the user has all the keys or when multiple users are involved. Allowing an user to create a signed transaction, export it and sent to another user who will import, sign and relay.

ranbena commented 5 years ago

Please assign this to me if possible

comountainclimber commented 5 years ago

@ranbena this task is officially assigned to you however it is not possible for me to assign contributors who do not have write access to the repo... Keep contributing and this wont be an issue 😄 for now assume it is assigned 👍

vncoelho commented 5 years ago

We have some example of javascript code for that at https://github.com/NeoResearch/neocompiler-eco/tree/master/public/js/eco-scripts, I can select each part for you @ranbena. We also used that template for the neonjs.

uvmetal commented 5 years ago

Is there any movement on this? I was planning to add multisign to neotools as a test and I could carry it over to this eventually.

This feature should be high priority to keep the wallet competitive with others in the space.

vncoelho commented 5 years ago

I believe it is on the way, @phetter. We have some javascript codes for this support, @comountainclimber: https://github.com/NeoResearch/neocompiler-eco/blob/master/public/js/eco-scripts/rawMultiSigConversions.js

https://github.com/NeoResearch/neocompiler-eco/blob/af79b9ff09f711a2476e9090d7dabcdc80e9d701/public/js/eco-scripts/transfers_NeonJS.js#L83-L178

Neon-js also added some support.

We are also doing a PR now on https://neocompiler.io for allowing multisig to invoke contracts: https://github.com/NeoResearch/neocompiler-eco/pull/55

Let's share these codes and make it happen! :dancer:

uvmetal commented 5 years ago

The code you provided here is great (https://github.com/NeoResearch/neocompiler-eco/blob/master/public/js/eco-scripts/rawMultiSigConversions.js). I will review further with plans to implement to neotools and neolink (these will be slow to happen as C.R.E.A.M.) :)

I like standard modules. <3

Thanks so much.

ranbena commented 5 years ago

Sry comrades. I am not on this assignment any more.

vncoelho commented 5 years ago

@comountainclimber

Time to go bouldering for a week and less snowboarding...kkkk ahauahah

check dylan https://cdn.discordapp.com/attachments/479084114629361675/565892228288086016/image0.jpg

comountainclimber commented 5 years ago

We are well on our way to supporting multi sig transaction signing as I am currently almost done with being able to import a transaction object for offline signing... It should be mostly trivial to support signing for multi sig transactions via this flow.

Support for generating a multi sig account will come shortly after 😃

comountainclimber commented 5 years ago

https://github.com/CityOfZion/neon-wallet/pull/1867