search

CityOfZion / neon-wallet

Light wallet for the NEO blockchain
http://neonwallet.com
MIT License
1.03k stars 312 forks source link

N3 CSV export fails when history is multiple pages #2738

Open hal0x2328 opened 3 months ago

hal0x2328 commented 3 months ago

How to reproduce:

  1. Log in to an N3 wallet with multiple pages of transactions
  2. Go to activity tab
  3. Hit the export button
  4. See that it never completes - if you look at the network console in developer tools it keeps requesting incrementing empty pages
Bazooka2304 commented 3 months ago

Thanks for highlighting this

thiagocbalducci commented 3 months ago

Hi!

I've attached this to one of our internal issues, we will work on it :)

Bazooka2304 commented 2 months ago

Hi, any update on this issue or even a workaround? Thanks

ixje commented 2 months ago

I've pinged @thiagocbalducci Might take until tomorrow to get a response

thiagocbalducci commented 2 months ago

Hey guys! Our internal issue is assigned, but we had to resolve some other priority topics before being able to tackle this one.

I will raise its priority and keep this gh issue updated about delivery.

Sorry for the delay!

Bazooka2304 commented 2 months ago

Thanks for the feedback. Much appreciated

Bazooka2304 commented 1 month ago

Hi, any update about this?

ixje commented 1 month ago

@thiagocbalducci @raulduartep ☝️

thiagocbalducci commented 1 month ago

Hi @Bazooka2304 fix is ready. We are testing the next build, aiming at delivering it this week.

thiagocbalducci commented 1 month ago

@Bazooka2304 this new version has the fix for this issue: https://github.com/CityOfZion/neon-wallet/releases/tag/v2.24.1

There are still improvements to be made, when there are tons of transactions, the loading communication disappears after a while, but it is still preparing your export, we've expedited this version so that users are at least able to get the file, but we will work on a more general improvement as well.

Sorry it took so long and thank you for your patience.

Bazooka2304 commented 1 month ago

@thiagocbalducci Thanks for the fix. I'm so happ now :)