search

CityScope / CSL_Hanoi

Repository dedicated to project related to Hanoi City
GNU General Public License v3.0
3 stars 2 forks source link

Support Arduino/Processing for TLU Presentation #24

Closed RoiArthurB closed 4 years ago

RoiArthurB commented 4 years ago

I've quickly re-organised the hardware/ folder to better include more content which can fit inside and all the code related to an Arduino support (with a README explaining step-by-step the installation process).

The GAMA model hasn't been changed too effectively for now (you can simply don't add this file if it bother you too much) and it should not break your Boston's setup :)

agrignard commented 4 years ago

Hi @RoiArthurB thank you for your interest on the project.

For now the arduino is simply sending one value to a processing script in order to control one parameter in GAMA. We are not planning to do more in term of Arduino controller for this project.

As you may know we are deploying it in few days a project that has been developed for almost 3 months now so any modification need to be first discussed and then carfully tested here to be sure not to introduce any bug. We will soon froze a release btw.

Can you be a bit more speciic about the change you are proposing in this pull request? Is it related to an existing issue? Just quick 2 points

Also do we want to keep you ".gitkeep" I see you commit some of this file in many of the folder.

RoiArthurB commented 4 years ago

The modification where to have a unified repo for any presentation with this project (in my case it was for a presentation we're doing at the Thuyloi University (TLU) ).

The good point was adding multiple pre-made works to setup it quickly with any hardware, etc. But if you don't want I have my fork I'll be working on and that's all.

I was simply thinking that having a single repo would be a good idea. But if you want to keep your master for your presentation just close this issue.

To answer your points :

PS: Mind to add a LICENCE to your repo, it's important !

agrignard commented 4 years ago

For obvious reason of stability and avoiding last-minute change this PR cannot be merge as it is (see #31)

Some answer to @RoiArthurB on his comment: The modification where to have a unified repo for any presentation with this project (in my case it was for a presentation we're doing at the Thuyloi University (TLU) ). => What do you mean by "a unified repo for any presentation with this project ", we have one repo for this project and its independant from any other project. The slider was just a bonus and actually the code is not in this repo.

The good point was adding multiple pre-made works to setup it quickly with any hardware, etc. But if you don't want I have my fork I'll be working on and that's all. => what is " multiple pre-made works"? , it can be a good idea to have something more unified for Arduino (even embedded in GAMA) but then dedicated issues and discussion should be initiated here https://github.com/gama-platform/gama

I was simply thinking that having a single repo would be a good idea. But if you want to keep your master for your presentation just close this issue. => "I was simply thinking that having a single repo would be a good idea" which repo are you speaking about? We only have one repo here ?

To answer your points :

"hardware" was not a very expressive name. Mainly because, on your repo, it only include some blueprints. So I've reordered it to have a tree more like a toolbox : hardware/ arduino - blueprints - other (that's the reason for the .gitkeep otherwise I can't commit empty folders) => yes the hardware is actually the laser grid file, As explained above, I simply wanted to have a unified repo for every presentations, not only the one you're currently preparing => which other presentation are you speaking about here? This project is a standalone and of course any generic tool developed in GAMA would be welcome to use. PS: Mind to add a LICENCE to your repo, it's important !_ => we don't use MIT Licence but GPL (see here https://github.com/CityScope/cityscope.github.io/wiki/About-Licences)