CityScope / CSL_Lima

0 stars 2 forks source link

Legoreader flip in the last commit version #25

Closed agrignard closed 5 years ago

agrignard commented 6 years ago

I try to update with one of your last version @vaap1997

however I think you have change lot of stuff and the 2 version are not exactly the same

for instance:

this is what I see with my version running (you can see that what you see on the left screen is the same as in the middle

screen shot 2018-10-18 at 10 37 36 am

however in the last commit version this is what I have and here you can see it s inverted.

screen shot 2018-10-18 at 10 39 50 am
vaap1997 commented 6 years ago

Hey! there is a flip attribute. If you press "f" on the keyboard it changes the flipped configuration.

agrignard commented 6 years ago

@vaap1997 even with the flip attribute it s not the same behavior

ion the current version what you see on the left is always the mirror of the right (even if you press f)

Would it be possible to have the same on the left and the the right? much more easy to understand for the user

vaap1997 commented 6 years ago

@jesusGarcia98 did it. I am sick right now... got hepatitis but he fix everything (You meet Jesus in one of our skypes)

agrignard commented 6 years ago

Ok thank for the change.

agrignard commented 6 years ago

.... I check your l'st commit I don4t know exactly what has been done in the 2 last commits but once agin it s not working...

it deems that the color code are not exactly working, are you also taking care the flip in the "patterns" windows?

It will be important to reach a stable version soon

agrignard commented 6 years ago

mmm ok so I think its question of flip

ok it s seems ok I just had to change the pattern ones, however we have to be careful with that kind of change, imagine if other people were using the same scanner they would also have to change everything.

do you have a table that is testing this script in lima?

agrignard commented 6 years ago

Ok I regot this issue after something like 4-5 hours of running

NullPointerException

I ll run a new version where I call

canvasOriginal.clear();

after begin draw() let see if it changes anything

agrignard commented 5 years ago

see issue #27