CityScope / CS_CityIO

Serverside script for the cityscope platform
https://cityio.media.mit.edu
14 stars 8 forks source link

[Format] angle consistancy #28

Closed yasushisakai closed 6 years ago

yasushisakai commented 6 years ago

In the header, it is declared to use radians in rotation, while each cell has rotation in degrees. Which do we want? (assuming both the direction is in clockwise)

popabczhang commented 6 years ago

Currently, for a lego piece in a grid system, we only have four different rotation values: 0 degree, 90 degree, 180 degree, and 270 degree. So I suggest to use integer "0, 1, 2, 3" instead, and have a mapping method in the header.

"mapping": {
      "rotation":{"0":"0 degree", "1":"90 degree conterclockwise", "2":"90 degree conterclockwise", "3":"90 degree conterclockwise"} // example, not requried
}
popabczhang commented 6 years ago

I am okay with either degree or radians. Agree that it needs to unify. I am okay with either clockwise or conterclockwise as well.

agrignard commented 6 years ago

@yasushisakai what do you mean by in the header? which one

I think it's just a question of convention we don't need to have a mapping as soon as we agree on the convention.

However I think it's more precise to use degree (especially for our case). 0,90,180 and 270 are int. Whereas how do you define PI? We will have some problem of precision here depending on the software used.

popabczhang commented 6 years ago

agree on the difficulty in defining Pi in different software. So we should use degree as well in 'angle' ? Let converge in tomorrow's meeting.

yasushisakai commented 6 years ago

we use degrees, counter clock wise