CityScope / CS_Proxymix

ABM framework to study spatial configuration and human behaviour at the building scale
10 stars 7 forks source link

Andorra FloorPlan building #175

Closed agrignard closed 3 years ago

agrignard commented 3 years ago

@jascensi and I will start to work on integrating some floorplan from Andorra in the current model. This issue is a test and a place holder to start the process and have a place to discuss about the requirement that are for now (and still need to be improved) here:

https://github.com/CityScope/CS_Proxymix/wiki

@jascensi welcome to the club and don't hesitate to ask question here or even edit or comment the wiki if you think it's not clear enough.

jascensi commented 3 years ago

We have received several floorplans from 2 different schools (one with a high rate of covid spreading and a second one with a low rate of covid spreading). I'll check the dxf files to meet the requirements

agrignard commented 3 years ago

OK great. looking forward to see the model running on it. Are you ok with the doc? https://github.com/CityScope/CS_Proxymix/wiki

Also most the exisitin floor plan are stored here (and where the potential Anodrra will be stored too) https://github.com/CityScope/CS_Proxymix/tree/master/ProxymixABM/includes

jascensi commented 3 years ago

OK great. looking forward to see the model running on it. Are you ok with the doc? https://github.com/CityScope/CS_Proxymix/wiki

Also most the exisitin floor plan are stored here (and where the potential Anodrra will be stored too) https://github.com/CityScope/CS_Proxymix/tree/master/ProxymixABM/includes

I'll let you know if if I have problems with the dxf formatting, and I'll check the existent floorplans at this link. Merci Arnaud!

jascensi commented 3 years ago

@agrignard , about dxf files and layers, is the model ok with the existance of layer that are not related to the model? For instance, "Fire prevention equipment" or " Electrical Install" layers should be locked, erased o hidden to avoid problems on the model? Or it doesn't mind?

agrignard commented 3 years ago

Very good question. It should not have any impact as we are filtering the layer at the initialization but anyway it will be good to test it

jascensi commented 3 years ago

Ok. I won't "clean up" any layer then. I'm also merging several "Walls" layers into a single one (some of the floorplans have a quite a specific layering depending on the characteristics of the walls; i.e, external or master walls are a in a different layer than inner or room walls)

agrignard commented 3 years ago

It's ok not to clean up the file even though it might be then to heavy. How difficult is it to remove the layer? One cool solution to streetest the tool is to have both files the one cleaned and the heavy one

jascensi commented 3 years ago

I have two floorplans: one from a low spreading rate school (A02_ORDINO_FRENCH_PRIMARY_SCHOOL_GROUND_FLOOR_ALL_LAYERS.dxf), and the other one from a high level spreading rate school (ANDORRAN_JUNIOR_HIGH-SCHOOL_ENCAMP_P1.dxf). Let's start with that to see if the layer naming and other stuff is working fine. Can you create a folder in includes please? I'll upload the content there.

agrignard commented 3 years ago

Yep the folder is here https://github.com/CityScope/CS_Proxymix/tree/master/ProxymixABM/includes

then you can create an Andorra folder and put your dxf inside

jascensi commented 3 years ago

I don't think I have the proper rights to create a folder nor to upload files

agrignard commented 3 years ago

I just updated your permission, you can now write.

So the idea is to clone the repo, make your change (adding your files) and then committing and pushing in the master branch so we can check together if it works

jascensi commented 3 years ago

Done! I added the folder and files. Crossing fingers to have done that correctly!

agrignard commented 3 years ago

@jascensi great start, I was able to integrate the building I did some renaming convention jsut to be sure it's compatible with the tool.

So there are some slight modification that will need to be done, mostly changing the Capital Case to lower case (I think this is a kind of AutoCad issue, from my knowledge it might be the version of Autocad you are using,) can you try to save it in 2013 format to be sure that the name of the layer are in Lower case?

This is the message error I have when trying to validate the dxf , so it really seems that the layer are here they just don't have the right name

Screenshot 2020-12-14 at 13 33 05
jascensi commented 3 years ago

@agrignard I changed the layers' names and saved as 2013 DXF version (I found some problems to do that on my Autocad for Mac, so we changed in Windows). I committed the changes with GitHub but I don't know if I did it well. Can you check please?

agrignard commented 3 years ago

I don't see the commit, did you commit and push?

jascensi commented 3 years ago

Jeez... I'm a noob 😓

agrignard commented 3 years ago

@jascensi I can now see you modifictation however it is still not working for the following reasons:

The name of the layer you are using doesn't match with the required one that can be found here https://github.com/CityScope/CS_Proxymix/wiki as mention in this page

A compatible dxf should specify at least

"Walls";"Entrance";"Offices" or "Meeting rooms";

So this is what the Gama validator errors shoes

Screenshot 2020-12-22 at 16 09 31

and this is what I see in Autocad (the layer naming convention is not respecting the Proxymix format)

Screenshot 2020-12-22 at 16 09 24

As an example the layer name e.g walls won't work it needs to be Walls with a capital W.

So I would suggest to carefully read the naming convention and be sure that all the required layer are well defined,

How does it sounds?

jascensi commented 3 years ago

My apologies @agrignard, I thought that layers should be named with small caps (from one of your previous messages). I'll change that asap

jascensi commented 3 years ago

Done!

agrignard commented 3 years ago

Not sure you psh the right file, can you push the .dxf not the .dwg?

jascensi commented 3 years ago

I did it but I will do it again. Maybe there is something that I'm missing out at Github

agrignard commented 3 years ago

It's getting there however according to this commit https://github.com/CityScope/CS_Proxymix/commit/b97df918edf4142640a0f444791ee575e6babd52

you changed some file but not the one called building.dxf.

The one I consider as the final one as the one called builidng.dxf in High_Covid19, Low_Covid19_Escaldes and Low_Covid19_Ordino folder

jascensi commented 3 years ago

This is weird... I have the dxf files (where I did the changes in the layers and so on) that it are in my local Github repository (picture below)

Captura de Pantalla 2020-12-22 a les 18 32 11

I pushed that on GitHub but it seems that you it didn't work. I don't really know what I'm missing but if you want to talk about that live, let me know and I'll send you a Teams link to do so

agrignard commented 3 years ago

What I am saying is that they don't haev the right name. they should be called building.dxf instead of ENCAMP_ANDORRAN_JUNIOR_HIGH-SCHOOL_1ST_FL. Even though you can keep this file if you want but the one that will be processed by GAMA is the one called building.dxf

agrignard commented 3 years ago

If you can just point me to the file you think are right then I will take care of renaming them

jascensi commented 3 years ago

Just pushed the files with the right name. Crossing fingers...

agrignard commented 3 years ago

Ok so first good step, Gama can now "read" the building.dxf however we are not done yet ;-)

Here is what I see when I run the validateDXF.gaml model which is just here for validation prupose

Screenshot 2020-12-22 at 19 28 38 Screenshot 2020-12-22 at 19 29 42 Screenshot 2020-12-22 at 19 30 07
agrignard commented 3 years ago

@jascensi can you have a look at this file to take example from. You should basically have the same structure. https://github.com/CityScope/CS_Proxymix/blob/master/ProxymixABM/includes/MediaLab/building.dxf

agrignard commented 3 years ago

Also it would be great if you can try to follow this steps so you can run by yourself the model in GAMA. It will be much more easier and faster if you can run it by yourself.

For the dxf production Can you let me know if this wiki is clear enough? If not let's udpate it https://github.com/CityScope/CS_Proxymix/wiki#dxf-production

jascensi commented 3 years ago

Happy New Year Arnaud! I'm introducing myself into the intricacies of using and running GAMA in my own system. I'll keep you posted about updates about the DXF floorplans and their results on GAMA.

agrignard commented 3 years ago

Happy new year to @jascensi looking forward to seing the progress on this topic!

agrignard commented 3 years ago

Hi @jascensi how is everything going? I just wanted to have some update in the floor plan of the school. According to Github we stil have some trouble running the tool on it. Any chance to iterate on this?

agrignard commented 3 years ago

Closing this issue for now. Anyone can be free to reopen it if there is a need from Andorra on this project