search

CityScope / CS_Urban_Indicators

Scripts for getting urban data and building urban indicators. A module for computing urban indicators in response to real-time CityScope inputs.
GNU General Public License v3.0
7 stars 4 forks source link

Indicators should return both raw and normalised values and units #20

Closed doorleyr closed 4 years ago

doorleyr commented 4 years ago

In order to allow a new reporting functionality on the front-end, the indicators should return raw values of indicators and units (where applicable) as well as the value normalised to (0,1).

eg. { 'name': Average Salary', 'value': 0.6, 'raw_value': 60000, 'units': 'USD' }

doorleyr commented 4 years ago

@crisjf can you check out this commit and make sure it's ok? Also, can you fill in units for your indicators if any? 9ee0ff69419932a0648961b457561f75cd9b9e73

crisjf commented 4 years ago

Hey! that looks good.

For the aggregate indicator, wouldn't you want to also return normalized and non-normalized values?

The only indicator that has units is the RnD one (millions of US dollars per capita). I added them in the last commit (a34eee9305d6da657a8ac785684e8795dd769b0c) and changed the scale of the raw value to a linear scale.

doorleyr commented 4 years ago

Thanks! The aggregate indicators are averages of other normalised indicators which may have different units so it wouldn't make sense to give them units.

crisjf commented 4 years ago

Makes sense! I think you can go ahead and close this issue.