Added Building layer - Githubissues

CityScope / CS_cityscopeJS

Create, design, and publish @CityScope projects on the web

https://cityscope.media.mit.edu/CS_cityscopeJS/

GNU General Public License v3.0

20 stars 16 forks source link

Added Building layer #17

Closed gok03 closed 4 years ago

gok03 commented 4 years ago

Included Building layer
Passed state from menu to map component for change listener

RELNO commented 4 years ago

@gok03 thanks! looks like componentWillReceiveProps is deprecated (see console) https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Also might worth pulling latest Master, since picking func is broken in your commit

gok03 commented 4 years ago

Working on the same now.

gok03 commented 4 years ago

Closing the PR to rebase the code.

gok03 commented 4 years ago

Also might worth pulling latest Master, since picking func is broken in your commit

master branch was latest in this PR. Can you give some info on picking func?

RELNO commented 4 years ago

Try pulling again, picking should be stable now. This is a selection method for multi cell editing. Also, last commit has crude layers control (based on what you’ve started doing), I’d appreciate your comments on that