Refactor and Styles - Githubissues

CityScope / CS_cityscopeJS

Create, design, and publish @CityScope projects on the web

https://cityscope.media.mit.edu/CS_cityscopeJS/

GNU General Public License v3.0

20 stars 16 forks source link

Refactor and Styles #70

Closed yzheng1998 closed 4 years ago

yzheng1998 commented 4 years ago

Cleaned up the code to make it more readable and speed up. Fixed minor bugs.

Styled darkmode

RELNO commented 4 years ago

@yzheng1998 can you merge your recent PR/ current Master with this? there are some naming changes that break this PR

Failed to compile.

./src/components/Screen/index.js
Cannot find file: 'index.js' does not match the corresponding name on disk: './src/components/Menu/menu'.

RELNO commented 4 years ago

Looks great, couple of notes:

apply color to submenus
the 4th icon is a placeholder for scenarios selector?
it looks that some of the docsMinsite styles are spilled into the map comp. (see the mapbox link at the bottom right). Do you know how to keep these styles independent?