search

CityWebConsultants / Iris

Modular content management and web application framework built with Node.js and MongoDB
http://irisjs.org
Other
9 stars 7 forks source link

JShint fixes in core files #138

Closed FilipNest closed 8 years ago

FilipNest commented 8 years ago

A few tricky ones left to do but bulk of it passes now. #134

FilipNest commented 8 years ago

All of the core non module files now pass JSHint. Onto modules now.

FilipNest commented 8 years ago

Done most of this but there are a few bits with scoping, functions in loops and such that probably point to a bit of minor refactoring to get it to work.

As we're using frontend stuff in some of the modules we're going to need to put in a slightly different config for some of the files so the config will sit at the top of the files. Or we can switch the global variable checker off completely.

This should probably be merged in soon to stop crazy amounts of conflicts if it's left too long. Then we can do another pull request for the next set which will be a lot smaller.