CityofSantaMonica / mds-provider

Python tools for working with MDS Provider data
https://github.com/openmobilityfoundation/mobility-data-specification
MIT License
18 stars 20 forks source link

use standard DBAPI conventions #33

Closed hunterowens closed 5 years ago

hunterowens commented 5 years ago

currently, MDS provider uses ProviderDataLoader(user, password, dbname, host, port) to connect to databases (Postgres?)

the more pythonic way to do this would be to accept engine configuration strings (for example, here is how SQLAlchemy does it. low priority issue of course.

thekaveman commented 5 years ago

You're right. It passes those args into sqlalchemy.create_engine, no reason NOT to be more Pythonic and accept other inputs to the __init__