Lean Client for Single Provider

CityofSantaMonica / mds-provider

Python tools for working with MDS Provider data

https://github.com/openmobilityfoundation/mobility-data-specification

MIT License

18 stars 20 forks source link

Lean Client for Single Provider #50

Closed johnclary closed 5 years ago

johnclary commented 5 years ago

This PR refactors api as a standalone package. It deviates from the original client in that it:

interfaces with only single provider
drops the internal auth.py and provider.py dependencies in favor of url, auth_type, token, and headers args.
does not interact with the provider registry at all or attempt OAuth

I don't expect this to be merged, but hopefully it contributes to the conversation around https://github.com/CityofSantaMonica/mds-provider/issues/35

thekaveman commented 5 years ago

@johnclary I'm not sure if you meant to submit this as a pull request, but I won't be able to accept this since it deletes the other parts of the library we are currently using in production.

I'm happy to discuss refactoring the ProviderClient or api module more to help your use-cases. You may also want to check out the work/ideas presented by @ezheidtmann in #46, which is similarly trying to improve the ProviderClient.

johnclary commented 5 years ago

@thekaveman i understand.

I don't expect this to be merged, but hopefully it contributes to the conversation around #35

Will look for activity on related issues and help where I can.

thekaveman commented 5 years ago

Definitely helps the conversation, thanks!

thekaveman commented 5 years ago

And apologies, I was too hasty in reading through your initial description and the code changes that I missed the line about this being more an exploration of an idea.