VDS notification failure

[gabrielwol]

• vds_pull.check_rows_vdsdata_div2 slack notification didn't work because of a None value returned from the SQLCheckOperatorWithReturnValue:

  File "/data/home/gwolofs/bdit_data-sources/dags/dag_functions.py", line 103, in task_fail_slack_alert extra_msg_str = '\n> '.join( TypeError: sequence item 3: expected str instance, NoneType found

• The slack alert shouldn't fail when a None is returned from SQLCheckOperatorWithReturnValue.
• The None was from the weather summary function weather.airport_weather_summary(date), because the weather pipeline runs at 10:30AM and the VDS pipeline runs earlier. We should move up this pipeline so all the volume pipelines can reference it.

[radumas]

There might be a reason the weather pipeline was scheduled for 10:30 AM

[gabrielwol]

There might be, but it's not mentioned in the docs and there is no readme page for scraping weather.gc.ca :) The package we use for predictions also doesn't mention anything. We can check results tomorrow. Likely it was just to make testing easier.