CityofToronto / bdit_king_pilot_dashboard

Dashboard for King St Pilot
GNU General Public License v3.0
4 stars 2 forks source link

Dashboard - Add NS Streets #82

Closed radumas closed 6 years ago

aharpalaniTO commented 6 years ago

Also: add tab for N/S streets (see #88)

radumas commented 6 years ago

Tabs added by https://github.com/CityofToronto/bdit_king_pilot_dashboard/commit/2343abdc41b9ff568adb07aa6ca7b37c1e5a7437

Will need to update STREETS global var mentioned above. Will need to modify display_content() callback function triggered by tabs to display the STREETS_LAYOUT when N/S data added. See https://github.com/CityofToronto/bdit_king_pilot_dashboard/blob/2343abdc41b9ff568adb07aa6ca7b37c1e5a7437/app.py#L373

radumas commented 6 years ago

Bit of a hurdle with the row_click() callback function. The callback doesn't fire if all of the Inputs don't exist. at the time of one of them firing the callback. Need to update this by splitting into two functions, one for each orientation of street.

https://github.com/CityofToronto/bdit_king_pilot_dashboard/blob/2343abdc41b9ff568adb07aa6ca7b37c1e5a7437/app.py#L423-L446