search

CivClassic / Citadel

A Minecraft plugin to protect your chests and builds using in-game materials. Requires an attacker to break each block a certain number of times. Built for Paper 1.16.5
BSD 3-Clause "New" or "Revised" License
1 stars 21 forks source link

Configurable CTI hologram size #84

Open squareblob opened 3 years ago

squareblob commented 3 years ago

Made a few weeks back and forgotten about until today, so may have some unintended jank...

Players can select how far in each direction holograms should extend from the block clicked (a maximum of 2 blocks in each direction from the block clicked). Peripheral holograms will only be visible if a raytrace succeeds. Traces are rate-limited, 1 hologram batch every 2 seconds.

The current theoretical cap is 3.1 traces per tick.

No idea how reasonable this number is, it could easily be adjusted 5-10 times lower if desired.

holo2

Diet-Cola commented 3 years ago

This is very cool

wingzero54 commented 3 years ago

This is a small gripe - but is it necessary to have three separate config options for each direction? It seems to me for usability and convenience, a single config option for 0-3 blocks out would be fine. The need to have a custom layout with it displaying holograms in x/z but not y directions for example seems small and makes it a touch more confusing and harder to use for the average player

squareblob commented 3 years ago

The initial reason for three separate config options was performance, as most usage will be on a flat-ish surface not requiring full depth in all dimensions. However, I never implemented a proper incentive for players to reduce the size of dimensions they are not using (eg. through capping the product of x,y,z instead of each config option individually) so a single dimension setting wouldn't change anything.

The other reason for three options is that there may be instances where large dimensions will lead to hologram spam at odd angles that block the players view of the holograms they are interested in. Been some time since I tested this so not sure it is a significant problem.

I agree it would be less confusing to have a single config option though, perhaps it could replace the current three and be coupled with an 'Advanced Hologram Settings' option for more fine-tuned configuration.