search

CivClassic / CivModCore

Plugin Core and general purpose API for Civ Plugins - Updated for Paper 1.16.5
BSD 3-Clause "New" or "Revised" License
2 stars 20 forks source link

ItemMap#removeSafelyFrom doesn't consume from offhand #25

Closed Maxopoly closed 4 years ago

Maxopoly commented 4 years ago

It should, but doesn't

https://github.com/CivClassic/CivModCore/blob/master/src/main/java/vg/civcraft/mc/civmodcore/itemHandling/ItemMap.java#L515

Can use /cte offhand reinforcing as test, it's broken rn because of that

Maxopoly commented 4 years ago

Fixed by https://github.com/CivClassic/CivModCore/pull/31