search

CivClassic / ExilePearl

For when you really just don't want that dude HERE but don't care if he plays - Paper plugin built for 1.16.5 Minecraft - Anti-grief tool built for players, not mods.
MIT License
0 stars 18 forks source link

Add config option for disabling summoning #19

Closed Lazersmoke closed 6 years ago

Lazersmoke commented 6 years ago

Why is summoning even a feature tbh?

Now you can disable it to remove its abusive aspects. Pearl holders must manually travel to the end to torment their prisoners instead of summoning them if this config option is disabled.

Lazersmoke commented 6 years ago

This is untested, and there might actually be a bug here: This entry in the config file doesn't match the entry in the config parser, namely one is pearls. and one isn't.

I copied that option for parsing this option, so if this is in fact a bug for that, it needs to be fixed in this PR as well.

Lazersmoke commented 6 years ago

Above was correct, fixed in 7821e53.

TealNerd commented 6 years ago

maybe a summon request to be confirmed by the player?

Lazersmoke commented 6 years ago

I have no idea why there is a merge commit there (probably cause I didn't pull 7821e53 before working on the confirmation).

Anyway, that has summon confirmation in it, but it's pretty rough. Needs lots of testing and polish. It probably won't crash the test server, but who knows tbh.

Lazersmoke commented 6 years ago

OK, Player works differently than I thought, corrected the other place this would have been an issue.

TealNerd commented 6 years ago

Did this locally because all the tasks and stuff were unnecessary https://github.com/CivClassic/ExilePearl/commit/66023da087e530d18ee7ebba8de98c79dda6f062