search

CivClassic / ExilePearl

For when you really just don't want that dude HERE but don't care if he plays - Paper plugin built for 1.16.5 Minecraft - Anti-grief tool built for players, not mods.
MIT License
0 stars 18 forks source link

Migrate playerheads back to pearls #61

Closed squareblob closed 4 years ago

squareblob commented 4 years ago

Fixes #60

An alternative fix would be to set the skull meta with appropriate base 64 encoding. The skin should then remain static and only lag on initial migration

Maxopoly commented 4 years ago

Did you test whether this properly migrates them back?

squareblob commented 4 years ago

Yes. On my test server which had both player head pearls and ender exile pearls everything appeared to migrate properly. All the pearls were repairable/freeable/locatable/kept their exclusion radius and every other property I tested behaved as expected.

Note that the pearls only migrate when createItemStack or validateItemStack are called so you would not be able to instantly " revert all git changes then to go back to the original state" (This is the same behavior as the initial PR (#59) but with migration direction reversed).

Maxopoly commented 4 years ago

Ok sounds good