CivClassic / ExilePearl

For when you really just don't want that dude HERE but don't care if he plays - Paper plugin built for 1.16.5 Minecraft - Anti-grief tool built for players, not mods.
MIT License
0 stars 18 forks source link

Fix EP error #97

Closed Diet-Cola closed 3 years ago

Protonull commented 3 years ago

Okay, we deduced that the error originated from Tuinity / Paper / Spigot since neither BanStick nor ExilePearl had been changed in any way for more than 10 days. We didn't exactly know how or why, so we created a command in ExilePearl to tell us whether it could access BanStick's database, and it couldn't. We added a scheduled repeating task to CivModCore that reflected its way to BanStick's database instance and lo and behold, it existed. So simultaneously it is accessible to CivModCore, which doesn't depend on BanStick, but isn't accessible to ExilePearl which does depend on BanStick.. weird. After looking at the POM we saw that BanStick was being shaded.

CivModCore was able to access BanStick's database because it was seeing BanStick's version of the code.. whereas ExilePearl and EssenceGlue (which depends on ExilePearl) was only seeing the shaded version of BanStick, which wasn't being used for anything thus lacked any database connections.

We believe that some change within Tuinity / Paper / Spigot has done something to further separate plugins from each other, hence why this problem only started within the last 48 hours after an upstream merge.

wingzero54 commented 3 years ago

The joys of being tied to Tuinity which automatically updates itself amirite

Protonull commented 3 years ago

It's not Tuinity's fault here, we would've had the same problem on Paper. Seems like the issue came from Spigot: https://github.com/PaperMC/Paper/commit/cb896d4710c2a827281f701682bbb8e0afff0818

wingzero54 commented 3 years ago

So our parent's parent's parent caused the issue

Protonull commented 3 years ago

Yup :P now just imagine if we were on Airplane, then it'd be our parent's parent's parent's parent's parent.