search

CivClassic / FactoryMod

Configurable factories for automating item production - Built for Paper 1.16.5
Other
2 stars 17 forks source link

Trapped chests don't make factories #12

Closed Xavter closed 4 years ago

Xavter commented 4 years ago

When making factories, if you use a trapped chest for the chest component, the factory won't build. QoL issue that seems like an easy fix - assigned to D4, feel free to move.

Maxopoly commented 4 years ago

Would need extensive testing as there are a lot of ways to break stuff with this change by not doing it properly

Maxopoly commented 4 years ago

Is there any actual reason though why you should be able to make factories from trapped chests? 1.14 let's you place chests of the same type adjacent to each other, so seems kinda pointless.

crimsonblod commented 4 years ago

Could the reason it's like this in the first place be related to the redstone signal that trapped chests put out?

Maxopoly commented 4 years ago

No, it's just easier with only a chest and there was never a strong reason for allowing trapped chests, even less so no.

Xavter commented 4 years ago

Is there any actual reason though why you should be able to make factories from trapped chests? 1.14 let's you place chests of the same type adjacent to each other, so seems kinda pointless.

Player confusion. People place trapped chests instead of chests when making factories, I've seen it happen a couple times at this point, one earlier today. I see no hard technical limitation to disallow trapped chest only factories, but it's good to know that it has land mines. Will label d3 tonight unless you state otherwise.

Maxopoly commented 4 years ago

Implemented by https://github.com/CivClassic/FactoryMod/pull/24