CivClassic / FactoryMod

Configurable factories for automating item production - Built for Paper 1.16.5
Other
2 stars 17 forks source link

Remove Observer Factory Activation #62

Open KaloHG opened 2 years ago

KaloHG commented 2 years ago

Observers are intended to "observe" objects. Not activate them.

Currently observers will spam activate factories that they are observing, resulting in many use cases (such as smart-activation switches) to be unusable due to this bug.

This patches that as such.

Heres a concept where an observer could be used to observe an auto compactor activate, and switch off the circuit in order to permit it to run through fully. (http://img.kayla.moe/javaw_rLF8iQqqWH.png)

caucow commented 2 years ago

It'd be better to add it with the diodes in FactoryModListener.redstoneChange(BlockRedstoneEvent), line 71, so people can still use them as trigger mechanisms but they respect direction.

They were overlooked when I fixed diodes triggering factories from any direction.