search

CivClassic / JukeAlert

A plugin that creates a new block in Minecraft that records player entries and actions. Anti-grief tool. Built for Paper 1.16.5
BSD 3-Clause "New" or "Revised" License
0 stars 18 forks source link

Disabling inactive snitches locks up server #43

Closed wingzero54 closed 3 years ago

wingzero54 commented 3 years ago

All snitches are parsed to check for inactive snitches and then deactivated on server startup. This locks up the server, and you are unable to connect to the server while it is disabling snitches. I presume this task needs to be made async?

wingzero54 commented 3 years ago

As an example, one day it took 6 minutes to deactivate or cull 500 snitches. That is almost one second for every snitch

Diet-Cola commented 3 years ago

More info on this: We've ruled out that disabling/culling snitches causes the start up lag, it is loading all snitches into memory on startup that stalls the start up of the server.

wingzero54 commented 3 years ago

See #52

wingzero54 commented 3 years ago

Fixed with #58 JukeAlert was loading all snitch logs into memory, which was taking 6 minutes on server startup, keeping ram usage higher and causing every GC to take longer. All of which has improved massively since snitch logs were removed from memory