search

CivClassic / RealisticBiomes

Minecraft plugin that limits plant growth and animal reproduction to their naturally occuring biomes, or reasonable ones for plants that do not occur naturally. Built for Paper 1.16.5
MIT License
1 stars 12 forks source link

Crops can fail to grow once their timer ends. #10

Closed Inframission closed 3 years ago

Inframission commented 4 years ago

Birch tree growth seems to fail randomly. Attempting to update ungrown saplings with a stick fails to spawn tree and yields one of two messages

Here's the result. after waiting 8 hours in a forest biome where growth time is 3 hours

Maxopoly commented 4 years ago

Strange. Likely there is an implementation fault in the update timers for crops, need to debug that. Could also be caused by low (<20) tps, not sure, need to make it tps independent if it is.

Random patches not growing anything were already reported for other crops as well, but we still haven't determined what exactly is different in those locations. Chunk borders maybe? Your screenshot makes it seem like the spots that didn't grow are chunk sized with a few exceptions in them.

Inframission commented 4 years ago

Random patches not growing anything were already reported for other crops as well, but we still haven't determined what exactly is different in those locations.

Patches in other crops do appear to be chunk related. Thinking the tree issue here is the same.

Maxopoly commented 4 years ago

These do have growth timers, so they were put into the database, but they never grew. Could you check whether keeping the chunk unloaded for 10 minutes and then loading it fixes those crops?

Inframission commented 4 years ago

Like the saplings, coming back to wheat after leaving it unloaded doesn't cause growth. Here's the result after waiting 9 hours - unplanted spots to the west are intentional

Edit: It seems the specific chunks where crops fail to grow changes over time. QtbV1KN

Maxopoly commented 4 years ago

Possibly fixed by https://github.com/CivClassic/RealisticBiomes/commit/0f4a3cb880c9eb6685c3add83a58896b61c93f93, please report back after restart

squareblob commented 4 years ago

0f4a3cb did not fix the issue. Crops still sometimes fail to grow

Maxopoly commented 4 years ago

Should be severely improved upon in https://github.com/CivClassic/RealisticBiomes/pull/25

Inframission commented 4 years ago

Testing myself, this issue seems resolved and I haven't seen feedback saying otherwise. Closing for now.

Maxopoly commented 4 years ago

Probably fixed by https://github.com/CivClassic/RealisticBiomes/commit/1c8b18d5b34f2be808c1a6503fd3550f633af5cc, but keeping the issue open until confirmed fixed

Maxopoly commented 3 years ago

Feedback on whether this was fixed by https://github.com/CivClassic/RealisticBiomes/commit/3a8fa6049d19889a0692f7a3780d81e2a24985b2 please

Maxopoly commented 3 years ago

Seemingly fixed