CivMC / Civ

Monorepo for development of and running a Civ Server.
MIT License
4 stars 11 forks source link

Proper /nldg confirmation #383

Closed drekamor closed 2 months ago

drekamor commented 3 months ago

People still delete group by accident because the command is similar to /nlsdg and the confirmation request is green (which implies safety of the operation)

okx-code commented 3 months ago

You can use NamedTextColor.RED instead of an RGB colour. It can also be provided as an argument in Component.text

awoo-civ commented 3 months ago

🎉

okx-code commented 3 months ago

Could you do the confirmation without an underscore?

drekamor commented 3 months ago

Could you do the confirmation without an underscore?

Sure. I just wasn't sure whether the command uses greedy string or normal string arguments. I'll look into it

drekamor commented 3 months ago

@okx-code I removed underscores from the message but I'm not sure whether the command takes a normal string argument or a greedy string

okx-code commented 3 months ago

Have you tested it?

drekamor commented 3 months ago

Not yet, need to build the plugin

drekamor commented 3 months ago

@okx-code image tested, seems to be working

awoo-civ commented 3 months ago

@drekamor Hmm, perhaps /nldg CONFIRM DELETION should be enclosed in quotes, i.e. Type '/nldg CONFIRM DELETION test' within 15 seconds. Should help disambiguate between the string that is to be typed and the rest of the sentence.

drekamor commented 3 months ago

@drekamor Hmm, perhaps /nldg CONFIRM DELETION should be enclosed in quotes, i.e. Type '/nldg CONFIRM DELETION test' within 15 seconds.. Should help disambiguate between the string that is to be typed and the rest of the sentence.

Was thinking about that as well. I'll add them

MrJeremyFisher commented 3 months ago

Imo the message shouldn't mention snitches and bastions as Citadel doesn't need to be run with Bastion and Jukealert and it won't necessarily be on other servers.

awoo-civ commented 3 months ago

That's up to the admins I suppose, but personally I'm vehemently against supporting anything other than the needs of CivMC if it requires any sacrifices.