search

CivMC / Civ

Monorepo for development of and running a Civ Server.
MIT License
4 stars 11 forks source link

Fix chunk meta not saving #391

Closed okx-code closed 2 months ago

okx-code commented 3 months ago

This PR fixes a race condition that casues chunk meta to not save chunks while they are loaded. The problem is that in the insert method, a ConcurrentModificationException can be triggered, as the list may also be modified from the main thread, which prevents saving. This was partially fixed in https://github.com/CivMC/Civ/pull/390 which will keep the executor running even when an exception is thrown, whereas before the executor would just never run again. This is a more permanent fix.

github-actions[bot] commented 3 months ago

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 156597b8e0fb90ddc3ddabc36d0af908ef120517
Logs https://github.com/CivMC/Civ/actions/runs/8438773073
Download https://github.com/CivMC/Civ/suites/22122997594/artifacts/