CivMC / Civ

Monorepo for development of and running a Civ Server.
MIT License
4 stars 10 forks source link

Remove PsuedoServer #552

Open okx-code opened 1 week ago

okx-code commented 1 week ago

It's annoying to maintain and not actually necessary

github-actions[bot] commented 1 week ago

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 3f2038481105851bbe6c3a2202f1d15ec27b35d8
Logs https://github.com/CivMC/Civ/actions/runs/9671506379
Download https://github.com/CivMC/Civ/suites/25315259052/artifacts/
Protonull commented 1 week ago

It's only "not actually necessary" because the tests that need it have been commented out. If you uncomment them, you'll see why it's necessary, but PseudoServer actually needs to be updated, which is why drafted #393.

Protonull commented 1 week ago

Perhaps a better solution would be moving it over to the test source set. It's otherwise just taking up space in the production jar when nothing other than the [commented out] tests need it.

okx-code commented 1 week ago

I'm not extending internal Bukkit classes

okx-code commented 1 week ago

FakePlayer from HiddenOre also needs to go but it's a mess to keep it while also keeping cave ore generation a thing

Protonull commented 1 week ago

I'm not extending internal Bukkit classes

Yeah, PseudoServer has the Minestom approach [of only adding what you need], whereas extending CraftServer would be the PaperMC approach [of disabling what you don't want]. PseudoServer was added back in the 1.16.4 days (before even the move to Gradle) to avoid spinning up a whole server (and figuring out where the server files should go and when they should be cleaned up) just to test some item stuff. Now that we have :runServer, this is far less of an issue.

okx-code commented 1 week ago

mockbukkit btw

Protonull commented 1 week ago

btw, mockbukkit != craftbukkit