search

Civcraft / Bastion

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Bastion
2 stars 9 forks source link

Publicly reinforced bastions allow for exploits #11

Closed ttk2 closed 9 years ago

ttk2 commented 9 years ago

so publicly reinforced bastions operate as you would expect any bastion to if everyone where on the gorup, no block break blocking, no pearl blocking, kinda useless, except you can place them, wait for maturity, then change the group, allowing a placed bastion to pretend to be a friendly one until you want to bring it out.

Clever, but not really the best of ideas. Bastion should just not operate on publicly reinforced blocks.

spaceFountain commented 9 years ago

This isn't just a problem with public reinforcement but reinforcement in general as you can add people as members to a group and then take them off later. A couple options we can do to maybe fix this. Add a bypass command and have bsi give the group information on all bastions covering the area. This way someone can see and brake a block even if they have access. Option two would be more complicated but would be to reset the maturity every time a change was made to it's group.

Question for option 1 would we still want to default to bypass as we do now?

ttk2 commented 9 years ago

Citadel 3.0 means you have to accept group invites, could fix this outright

On Sun Jan 25 2015 at 8:58:13 AM spaceFountain notifications@github.com wrote:

This isn't just a problem with public reinforcement but reinforcement in general as you can add people as members to a group and then take them off later. A couple options we can do to maybe fix this. Add a bypass command and have bsi give the group information on all bastions covering the area. This way someone can see and brake a block even if they have access. Option two would be more complicated but would be to reset the maturity every time a change was made to it's group.

Question for option 1 would we still want to default to bypass as we do now?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Bastion/issues/11#issuecomment-71376142.

spaceFountain commented 9 years ago

So I could make it so every time the group is changed on a block maturity is reset. AKA if you change it from public to private. Or I could just make it so everyone isn't counted under the publicness of the reinforcement. @rourke750 what have you done in the past though to deal with the fact that bastion appears to have been updated for Citadel 3. Is it backwards compatible or should I deal with a comment before it was updated and just compile separately.

rourke750 commented 9 years ago

For public groups do you want bastions to still take damage and let people place or just not allow bastions to be reinforced publicly?

erocs commented 9 years ago

Probably shouldn't be allowed. On Feb 1, 2015 11:26 AM, "rourke750" notifications@github.com wrote:

For public groups do you want bastions to still take damage and let people place or just not allow bastions to be reinforced publicly?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Bastion/issues/11#issuecomment-72379569.

rourke750 commented 9 years ago

https://github.com/Civcraft/Bastion/commit/eca628b601b348fd5869f5c9fb2eaf803c036e7f

spaceFountain commented 9 years ago

Can we also maybe get an event from Citadel when the group on a block changes? I think it probably aught to reset the maturity when it happens. Or does that trigger a reinforcement created event

rourke750 commented 9 years ago

When a reinforcement on a group changes it fires the reinforcementcreationevent On Sun, Feb 1, 2015 at 3:35 PM, spaceFountain notifications@github.com wrote:

Can we also maybe get an event from Citadel when the group on a block changes? I think it probably aught to reset the maturity when it happens.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Bastion/issues/11#issuecomment-72382869.