search

Civcraft / Bastion

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Bastion
2 stars 9 forks source link

Add comments into config.yml #31

Open ShadedJon opened 9 years ago

ShadedJon commented 9 years ago

Added comments for most of the config options. I am unsure what EnderPearl's scaleFac does.

Maxopoly commented 9 years ago

Thanks for adding this, the documentation of Bastion is kinda sketchy

Ender pearl scale fac is how much damage a pearl deals to the bastion. Also could you sign the CLA, it can't be merged before that.

spaceFountain commented 9 years ago

As compared to how much it would do if someone placed a block.

On Fri, Oct 16, 2015 at 7:10 AM Max Baumstark notifications@github.com wrote:

Thanks for adding this, the documentation of Bastion is kinda sketchy

Ender pearl scale fac is how much damage a pearl deals to the bastion. Also could you sign the CLA, it can't be merged before that.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Bastion/pull/31#issuecomment-148686011.

ShadedJon commented 9 years ago

Signed.

Maxopoly commented 9 years ago

Could you add a line for enderpearl scaleFac?

idoash4 commented 9 years ago

You should be placing comments in the top part of the file, before any uncommented text. Otherwise the comments will be deleted if the plugin edits the file (e.g a command that changes the value of one of the settings and requires the plugin to edit the file and save it).

ShadedJon commented 9 years ago

@BlackXnt can you explain more what you mean by your last comment?

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.