search

Civcraft / BetterShards

A bukkit mod that supports Civcraft's plugin and sharding.
BSD 3-Clause "New" or "Revised" License
8 stars 8 forks source link

BetterShardsBungee needs the same plugin name #105

Closed erocs closed 8 years ago

erocs commented 8 years ago

Currently BetterShardsBukkit and BetterShardsBungee share the same plugin name. That leads to the problem where the Bukkit jar is placed in a bungeecord's plugins directory and other plugins "depends: [BetterShards]" allows the other plugins to load even though BetterShardsBungee doesn't exist.

Rename the BetterShardsBungee plugin name to BetterShardsBungee.

ProgrammerDan commented 8 years ago

So the issue here isn't the naming of the plugins.

On build, the plugins are very clearly labelled.

BetterShardsBukkit.jar

and

BetterShardsBungee.jar

No issues are to be found there.

The issue is simply how the deploy mechanism is constructed demands that we strip all version and identifying information from the jars, and rename it to match the plugin name.

That's the source of the problem, IMHO.

Maxopoly commented 8 years ago

I think the plugin names are fine, the issue is the deploy thing.