search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Fix for Pistons #102

Closed idoash4 closed 9 years ago

idoash4 commented 9 years ago

I tested it, seems to be working. More testing should be done on civtest.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

WildWeazel commented 9 years ago

ok to test

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Citadel-pull/2/ Test PASSed.

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Citadel-pull/2/ Test PASSed.

WildWeazel commented 9 years ago

http://192.99.169.83:8080/job/Citadel-master/132/

rourke750 commented 9 years ago

@ttk2

ttk2 commented 9 years ago

on civtest, staged for tomorrow.

On Sun, May 24, 2015 at 3:48 PM rourke750 notifications@github.com wrote:

@ttk2 https://github.com/ttk2

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/102#issuecomment-105060827.

idoash4 commented 9 years ago

Ok I did more testing on civtest and everything is working. This change also fixes the old problem with normal piston not retracting after touching a reinforced block.

ttk2 commented 9 years ago

sounds great, its staged for restart, thanks a ton!

On Sun, May 24, 2015 at 4:55 PM BlackXnt notifications@github.com wrote:

Ok I did more testing on civtest and everything is working. This change also fixes the old problem with normal piston not retracting after touching a reinforced block.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/102#issuecomment-105064807.

ttk2 commented 9 years ago

you are in the dev group now right?

On Sun, May 24, 2015 at 5:15 PM justin kilpatrick < kilpatrickjustin@gmail.com> wrote:

sounds great, its staged for restart, thanks a ton!

On Sun, May 24, 2015 at 4:55 PM BlackXnt notifications@github.com wrote:

Ok I did more testing on civtest and everything is working. This change also fixes the old problem with normal piston not retracting after touching a reinforced block.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/102#issuecomment-105064807.

idoash4 commented 9 years ago

I am in the github dev group someone made a few days ago, not sure if there are any other groups.

ttk2 commented 9 years ago

there is a google email group, do you want an invite?

On Sun, May 24, 2015 at 5:27 PM BlackXnt notifications@github.com wrote:

I am in the github dev group someone made a few days ago, not sure if there are any other groups.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/102#issuecomment-105072021.

idoash4 commented 9 years ago

Sure, my email: blackxnt@gmail.com.