search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Adding non reinforceable materials for a specific type of reinforcement #105

Closed idoash4 closed 9 years ago

idoash4 commented 9 years ago

This will solve the problem of diamond block reinforcement been abused to make OP vaults. We can just prevent players from reinforcing obsidian or beacons with a diamond block. An example of how the config.yml should be edited:

diamond_block: material: DIAMOND_BLOCK requirements: 1 return: 1 percent_chance: 100 hit_points: 5000 /# mature time is in minutes mature_time: 1440 scale_amount: 0 lore: non_reinforceables:

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ProgrammerDan commented 9 years ago

Looks clean, if this feature is desired this should accomplish it no fuss. @BlackXnt you should probably embed your pull description of how to use the feature into the config.yml as new comments.

idoash4 commented 9 years ago

@ProgrammerDan Done.

WildWeazel commented 9 years ago

ok to test

CivcraftBot commented 9 years ago

Build finished.

ProgrammerDan commented 9 years ago

Can't speak on completeness, but the changes look internally good.

idoash4 commented 9 years ago

I tested the changes my server, they are working.

ProgrammerDan commented 9 years ago

Clearly this is targetted against new blocks, but if an existing block in the non-reinforcement list is already reinforced, what happens when you attempt to interact with that reinforcement?

idoash4 commented 9 years ago

You will be able to change the reinforcement. I can change it but is it even necessary? Currently you will be able to interact with reinforced blocks that are on the "general" non-reinforcement list too.

ProgrammerDan commented 9 years ago

Probably not necessary, especially since "desired" behavior is entirely undefined at this point. Was just wracking my brain trying to think of any, if any, potential regressions.

ttk2 commented 9 years ago

this is IHMO against the spirit of Citadel and Civcraft plugin design. If we have to do this I would rather reinforcements be buffed on specific items like chests than have exclusive reinforcement levels.

ProgrammerDan commented 9 years ago

@ttk2 Care to weigh in on http://forum.civcraft.co/t/citadel-diamond-block-reinforcements/441/20 concerning motivation for Dblock reinforcement at all?

ttk2 commented 9 years ago

matta should have his comments up soon, for the time being we will try and make shops chests feasible other ways, closing for now but I may ropen this later.