search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Acid blocks usuable by members of same group? #108

Closed ghost closed 9 years ago

ttk2 commented 9 years ago

I think that's how its supposed to work?

ghost commented 9 years ago

Members don't have blocks perm so I would think that they'd need at least that perm to use acid blocks on the same group since it accomplishes the same thing.

On 6/22/15, ttk2 notifications@github.com wrote:

I think that's how its supposed to work?

Reply to this email directly or view it on GitHub: https://github.com/Civcraft/Citadel/issues/108#issuecomment-114299284

jjj5311 commented 9 years ago

I think it is working correctly, players need to have the BLOCKS permission to modify reinforcements

https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/reinforcement/PlayerReinforcement.java#L67

ghost commented 9 years ago

The player who discovered this received the message that they do not have the permission to use the acid block, but the acid block popped anyway.

PromoFaux commented 9 years ago

Hi, Yeah that was me... But also, I think I've found the problem:

https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/command/commands/Acid.java#L69

1. Player has permission:
      -Continue
      -break block (providing all other requirements met)

2. Player does not have permission:
      -Display message "you do not have sufficient... blah blah"
      -SHOULD RETURN HERE, BUT:
      -Fall out of if block
      -Break block (providing all other requirements met)

You're missing a return :)

(EDIT: I'd fiddle and test this, but I've fallen over at maven dependencies)

jjj5311 commented 9 years ago

Good catch

On Tuesday, June 23, 2015, adzjwarner notifications@github.com wrote:

Hi, Yeah that was me... But also, I think I've found the problem:

https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/command/commands/Acid.java#L69

  1. Player has permission: -Continue -break block (providing all other requirements met)
  2. Player does not have permission: -Display message "you do not have sufficient... blah blah" -SHOULD RETURN HERE BUT: -Fall out of if loop -Break block (providing all other requirements met)

You're missing a return :)

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/108#issuecomment-114403710.

ghost commented 9 years ago

Sounds like a quick fix. Any volunteers?

ghost commented 9 years ago

Woops, didn't mean to close issue.

I've staged it on civtest. I'll restart civtest in a bit once current testers are off.

ghost commented 9 years ago

Huh, got a bunch of Unknown dependency CivModCore and other stuff when I put this on. Probably due to other changes?

@rourke750

org.bukkit.plugin.UnknownDependencyException: CivModCore at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:219) [spigot.jar:git-Spigot-1d14d5f-7722428] at org.bukkit.craftbukkit.v1_8_R2.CraftServer.loadPlugins(CraftServer.java:291) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.DedicatedServer.init(DedicatedServer.java:199) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-1d14d5f-7722428] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45-internal] 2015-06-23 11:14:07 [ERROR] Could not load 'plugins/JukeAlert-1.3.1.jar' in folder 'plugins' org.bukkit.plugin.UnknownDependencyException: Citadel at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:219) [spigot.jar:git-Spigot-1d14d5f-7722428] at org.bukkit.craftbukkit.v1_8_R2.CraftServer.loadPlugins(CraftServer.java:291) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.DedicatedServer.init(DedicatedServer.java:199) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-1d14d5f-7722428] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45-internal] 2015-06-23 11:14:07 [ERROR] Could not load 'plugins/Bastion-1.0.1.jar' in folder 'plugins' org.bukkit.plugin.UnknownDependencyException: Citadel at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:219) [spigot.jar:git-Spigot-1d14d5f-7722428] at org.bukkit.craftbukkit.v1_8_R2.CraftServer.loadPlugins(CraftServer.java:291) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.DedicatedServer.init(DedicatedServer.java:199) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-1d14d5f-7722428] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45-internal] 2015-06-23 11:14:07 [ERROR] Could not load 'plugins/FactoryMod-1.4.0-22.jar' in folder 'plugins' org.bukkit.plugin.UnknownDependencyException: Citadel at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:219) [spigot.jar:git-Spigot-1d14d5f-7722428] at org.bukkit.craftbukkit.v1_8_R2.CraftServer.loadPlugins(CraftServer.java:291) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.DedicatedServer.init(DedicatedServer.java:199) [spigot.jar:git-Spigot-1d14d5f-7722428] at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-1d14d5f-7722428] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45-internal] 2015-06-23 11:14:07 [ERROR] Could not load 'plugins/ItemExchange-1.0.0-1.jar' in folder 'plugins' org.bukkit.plugin.UnknownDependencyException: Citadel

ttk2 commented 9 years ago

Yup other changes. Just toss it on Civtest juenkins has core builds.

On Tue, Jun 23, 2015, 10:16 AM Dr. Andrew Jawa notifications@github.com wrote:

Huh, got a bunch of Unknown dependency CivModCore and other stuff when I put this on. Probably due to other changes?

@rourke750 https://github.com/rourke750

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/108#issuecomment-114540522.

ghost commented 9 years ago

Even though it is saying it couldn't load dependencies?

Just checking to be sure

rourke750 commented 9 years ago

No you need to add CivModCore as well. On Jun 23, 2015 1:25 PM, "Dr. Andrew Jawa" notifications@github.com wrote:

Even though it is saying it couldn't load dependencies?

Just checking to be sure

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/108#issuecomment-114578498.

ghost commented 9 years ago

Done seems to work. Only bergecore complained.

ttk2 commented 9 years ago

they might have to live in harmony someday, but it should probably be removed for today.

jjj5311 commented 9 years ago

@drjawa did you ever get confirmation that this is solved?

ghost commented 9 years ago

Yeah, the fix is live so this shall be closed.

On 7/1/15, jjj5311 notifications@github.com wrote:

@drjawa did you ever get confirmation that this is solved?

Reply to this email directly or view it on GitHub: https://github.com/Civcraft/Citadel/issues/108#issuecomment-117706417