search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Agressive fire suppression #111

Open WildWeazel opened 9 years ago

WildWeazel commented 9 years ago

https://forum.civcraft.co/t/fire-spread-is-an-unbalanced-bypass-of-citadel/744?u=wildweazel

Berge messed up our revision history so I won't try to merge but here's the diff that did it: a4e12fb0c7ae2487d6253144ef8b5bbd388c92b8

WildWeazel commented 9 years ago

basically https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/listener/BlockListener.java#L259 and down needs to be uncommented and preferably wrapped in a config option

ttk2 commented 9 years ago

sounds easy enough.

WildWeazel commented 9 years ago

no takers? guess I can knock this out tomorrow

ProgrammerDan commented 9 years ago

might be easier to just suppress BlockSpreadEvent for type Fire then the complex logic here?

WildWeazel commented 9 years ago

that should work too. from or to a reinforced block, or both?

ttk2 commented 9 years ago

just to reinforced blocks I would say.

suirad commented 8 years ago

So all that needs to be done here is to trim the BlockBurnEvent hook to just https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/listener/BlockListener.java#L259 and then add a hook for BlockSpreadEvent to cancel for fire if block is reinforced?

suirad commented 8 years ago

Quoting @erocs from #119 to merge issues

Preventing reinforced block ignition might provide a much better protection against fires for such materials. The reinforcement's durability should still take a damage when cancelled.