search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Adding bedrock reinforcement #122

Closed Maxopoly closed 8 years ago

Maxopoly commented 8 years ago

@rourke750

Can I just merge this or do I need to do anything else? That's for jacky.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ttk2 commented 8 years ago

is it safe to use int_max exactly? Should we subtract a couple hundred from it to be safe?

Maxopoly commented 8 years ago

It's int_max -1, in theory we should be safe, but we might as well just subtract a couple hundred if rourke thinks there are any possible issues.

rourke750 commented 8 years ago

@Maxopoly It would be more of an @erocs question. I dont have a very good understanding of the undergoings of programming.

erocs commented 8 years ago

Why is a bedrock reinforcement being added? Set maturity to 0? The hit_points should be fine.

On Sat, Oct 3, 2015 at 10:47 PM, rourke750 notifications@github.com wrote:

@Maxopoly https://github.com/Maxopoly It would be more of an @erocs https://github.com/erocs question. I dont have a very good understanding of the undergoings of programming.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/122#issuecomment-145319593.

ttk2 commented 8 years ago

for admin stuff in new shards.

rourke750 commented 8 years ago

We want the maturation to be at least higher than diamond so no one can reinforce it. It might be a good idea to add a new option in the config and specify which reinforcements can be used to acid block it.

erocs commented 8 years ago

There should be a hard coded prevention against acid blocking bedrock and ender portal blocks. Or at least there was in 2.0...

N

On Sun, Oct 4, 2015 at 7:22 AM, rourke750 notifications@github.com wrote:

We want the maturation to be at least higher than diamond so no one can reinforce it. It might be a good idea to add a new option in the config and specify which reinforcements can be used to acid block it.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/122#issuecomment-145353900.

Maxopoly commented 8 years ago

There already is a prevention against acidblocking bedrock, but I dont see how that's relevant here.

Reinforcements reinforced with bedrock, could only be acidblocked with bedrock reinforced acidblocks and obviously noone is gonna have those, thats a non-issue as long as we leave the maturation higher than the diamond maturation.

erocs commented 8 years ago

I was attempting to figure out why maturation even maters. I may have slightly mis-read Rourke's text, but the only place where it should matter is with acid blocks. Of course, Citadel3 is different in weird ways from 2 so go forth and change it.

On Sun, Oct 4, 2015 at 11:56 AM, Max Baumstark notifications@github.com wrote:

There already is a prevention against acidblocking bedrock, but I dont see how that's relevant here.

Reinforcements reinforced with bedrock, could only be acidblocked with bedrock reinforced acidblocks and obviously noone is gonna have those, thats a non-issue as long as we leave the maturation higher than the diamond maturation.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/122#issuecomment-145374957.

rourke750 commented 8 years ago

Citadel 3.0 also allows scale damaging based on maturation so that's why it matters, also with acid blocks.

Maxopoly commented 8 years ago

So how should I change it? Right now maturation_time is INT_MAX -1

ttk2 commented 8 years ago

bumping for @rourke750

rourke750 commented 8 years ago

This is all good. @Maxopoly Merge whenever you feel.