Open psygate opened 8 years ago
https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/database/CitadelReinforcementData.java introduces a lore field which at best artificially limits lore to be 255 characters and fail to store the whole reinforcements if longer and at worst introduce a lot of query overhead by making the field nullable / varchar(255).
The lore should be split into a different table, where each line can be stored as a row with a synthetic key to store in the reinforcement. An integer can be used to signify if it is necessary to perform another query and retrieve the lore.
https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/database/CitadelReinforcementData.java introduces a lore field which at best artificially limits lore to be 255 characters and fail to store the whole reinforcements if longer and at worst introduce a lot of query overhead by making the field nullable / varchar(255).
The lore should be split into a different table, where each line can be stored as a row with a synthetic key to store in the reinforcement. An integer can be used to signify if it is necessary to perform another query and retrieve the lore.